Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mobile): disable swipe back gesture when there is no back in header #8876

Merged
merged 1 commit into from
Nov 25, 2024
Merged

feat(mobile): disable swipe back gesture when there is no back in header #8876

merged 1 commit into from
Nov 25, 2024

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Nov 20, 2024 •
edited
Loading

close AF-1663, AF-1756

  • new global ModalConfigContext
  • new logic to judge whether inside modal
  • render ✕ for PageHeader back if inside modal
  • only enable NavigationGesture when there is < in PageHeader

@graphite-app Graphite App
Copy link

graphite-app bot commented Nov 20, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@CatsJuice Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Nov 20, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b369ee0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@CatsJuice CatsJuice marked this pull request as ready for review November 21, 2024 02:11
@CatsJuice CatsJuice force-pushed the catsjuice/feat/ios-nav-gesture-control branch from 23e31d5 to 454363d Compare November 22, 2024 02:07
@codecov Codecov
Copy link

codecov bot commented Nov 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 70.24%. Comparing base (922db5c) to head (b369ee0).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
packages/frontend/component/src/ui/modal/modal.tsx 14.28% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           canary    #8876      +/-   ##
==========================================
+ Coverage   70.19%   70.24%   +0.04%     
==========================================
  Files         550      551       +1     
  Lines       34005    34014       +9     
  Branches     3052     3053       +1     
==========================================
+ Hits        23871    23894      +23     
+ Misses       9762     9748      -14     
  Partials      372      372
Flag Coverage Δ
server-test 77.14% <ø> (+0.06%) ⬆️
unittest 46.06% <33.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@CatsJuice CatsJuice force-pushed the catsjuice/feat/ios-nav-gesture-control branch from 454363d to b3200bd Compare November 22, 2024 07:51
@CatsJuice CatsJuice force-pushed the catsjuice/feat/ios-nav-gesture-control branch from b3200bd to 387a90a Compare November 22, 2024 08:14
@CatsJuice CatsJuice force-pushed the catsjuice/feat/ios-nav-gesture-control branch from 387a90a to 8443371 Compare November 22, 2024 08:34
@CatsJuice CatsJuice force-pushed the catsjuice/feat/ios-nav-gesture-control branch from 8443371 to f93f071 Compare November 25, 2024 01:44
@graphite-app Graphite App
Copy link

graphite-app bot commented Nov 25, 2024 •
edited
Loading

Merge activity

@CatsJuice
feat(mobile): disable swipe back gesture when there is no back in hea…
b369ee0 
…der (#8876)

close AF-1663, AF-1756

- new global `ModalConfigContext`
- new logic to judge whether inside modal
- render `✕` for PageHeader back if inside modal
- only enable `NavigationGesture` when there is `<` in PageHeader
@EYHN EYHN force-pushed the catsjuice/feat/ios-nav-gesture-control branch from f93f071 to b369ee0 Compare November 25, 2024 03:12
@graphite-app graphite-app bot merged commit b369ee0 into canary Nov 25, 2024
47 checks passed
@graphite-app graphite-app bot deleted the catsjuice/feat/ios-nav-gesture-control branch November 25, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@EYHN EYHN EYHN left review comments

@pengx17 pengx17 pengx17 approved these changes

@forehalo forehalo Awaiting requested review from forehalo

@JimmFly JimmFly Awaiting requested review from JimmFly

Assignees
No one assigned
Labels
app:core mod:component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CatsJuice @pengx17 @EYHN